search

o3de / sig-release

8 stars 20 forks source link

Make a determination on Snap Packaging #178

Closed tonybalandiuk closed 1 year ago

tonybalandiuk commented 1 year ago

Raised by @amzn-changml in 4/20 release prep meeting. We need to determine if Snap Packaging will make it or not. @chanmosq , @tonybalandiuk , Nicole H need to be informed so that we can account for it in release notes, announcement, etc.

amzn-changml commented 1 year ago

To list out the current issues:

- The snap package in its current state as of 1259429 will not install a working executable. Starting o3de will result in a error loading libQt5Concurrent.so.5. This is filed as a bug here: https://github.com/o3de/o3de/issues/15581 and to be fixed with this PR: https://github.com/o3de/o3de/pull/15735 https://github.com/o3de/o3de/pull/15735 Merged in and resolved the issue

- There is a secondary issue with the project manager. There is an error detecting and pulling Python into the O3DE snap folder inside /snap/ (which probably shouldn't be writable). A bug is filed here: https://github.com/o3de/o3de/issues/14902 https://github.com/o3de/o3de/pull/15735 Merged in and preliminary testing has showed that the issue has been resolved. LB has confirmed that this is no longer an issue.

Update as of 4/25 The snap package and python detection issue has been resolved by https://github.com/o3de/o3de/pull/15735. I've updated the above to reflect the current state

vincent6767 commented 1 year ago

Do you know what's the next action item for this? @Naomi-Wash @tonybalandiuk

Naomi-Wash commented 1 year ago

I do believe @Ulrick28 said something about a point release for this. Joe - can you please elaborate?

tonybalandiuk commented 1 year ago

Overall, a point release is something that SIG-Release would make the call on and coordinate, but we would need input from the rest of the project on: A) whether we should have a point release B) do we have volunteers create the point release

We don't have a documented process for a point release - we haven't had to do one yet. They have to happen at some point, though, and the process would basically be a subset of the major release steps.

Ulrick28 commented 1 year ago

Snap packaging should not need a point release, unless we have to make code changes to O3DE itself, which we shouldn't for packaging.

However, there is talk of a point release for other reasons, but that requires a more in depth conversation and data gathering on specific issues to be addressed by a point release.

Joe B.

From: Tony Balandiuk @.> Sent: Tuesday, May 9, 2023 1:38 AM To: o3de/sig-release @.> Cc: Bryant, Joe @.>; Mention @.> Subject: Re: [o3de/sig-release] Make a determination on Snap Packaging (Issue #178)

Overall, a point release is something that SIG-Release would make the call on and coordinate, but we would need input from the rest of the project on: A) whether we should have a point release B) do we have volunteers create the point release

We don't have a documented process for a point release - we haven't had to do one yet. They have to happen at some point, though, and the process would basically be a subset of the major release steps.

- Reply to this email directly, view it on GitHubhttps://github.com/o3de/sig-release/issues/178#issuecomment-1539188652, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARAYZKBFDIJ7CYHFIREDANTXFH66ZANCNFSM6AAAAAAXF52OE4. You are receiving this because you were mentioned.Message ID: @.**@.>>

vincent6767 commented 1 year ago

Thanks @Ulrick28 . Few questions

  1. I believe whoever works on Snap packaging will raise to SIG release if there are any code changes on the O3DE so we can introduce point release. Can I safely assume that?
  2. Can you elaborate further on what other reasons for point release?

CC: @tonybalandiuk

vincent6767 commented 1 year ago

Hi @Ulrick28 Are there any updates on this issue? Just wondering whether we have completed this or not.

vincent6767 commented 1 year ago

Resolved as it's not part of the blockers for 23.05.