o5 / grido

Grido - DataGrid for Nette Framework
http://o5.github.io/grido-examples/
MIT License
90 stars 88 forks source link

Distribution files not updated #312

Closed peterpp closed 1 year ago

peterpp commented 2 years ago

Function initFilters() in assets/dist/js/* is different than in assets/js/grido.js and contains a bug. I understand that project is not maintained, but this can be fixed easily... for people that still use dev version in some older stuff.

o5 commented 2 years ago

Could you send the PR with fix of the bug, please?

peterpp commented 1 year ago

I tried... and failed. Command npm install returns this error:

npm ERR! gyp: Undefined variable standalone_static_library in binding.gyp while trying to load binding.gyp
npm ERR! gyp ERR! configure error 
npm ERR! gyp ERR! stack Error: `gyp` failed with exit code: 1
npm ERR! gyp ERR! stack     at ChildProcess.onCpExit (/Users/peter/Projects/grido/node_modules/node-gyp/lib/configure.js:345:16)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
npm ERR! gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:293:12)
npm ERR! gyp ERR! System Darwin 21.6.0
npm ERR! gyp ERR! command "/opt/homebrew/Cellar/node/19.3.0/bin/node" "/Users/peter/Projects/grido/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
npm ERR! gyp ERR! cwd /Users/peter/Projects/grido/node_modules/node-sass
npm ERR! gyp ERR! node -v v19.3.0
npm ERR! gyp ERR! node-gyp -v v3.8.0
npm ERR! gyp ERR! not ok

I'm not familiar with NPM and Node, so I don't know how to fix it.

peterpp commented 1 year ago

@o5 Here it is 👆