search

o5r / lemonway

5 stars 2 forks source link

Refactor to ES6 #27

Open vanwalj opened 7 years ago

vanwalj commented 7 years ago

Hi, Do you consider moving to ES6?

vanwalj commented 7 years ago

😞

PierrickP commented 7 years ago

it's open source, you can make a pull request :wink:

vanwalj commented 7 years ago

Sure, just wanted to be sure it will not be rejected ;) On Mon, 13 Mar 2017 at 09:20, Pierrick PAUL notifications@github.com wrote:

it's open source, you can make a pull request 😉

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Lendix/lemonway/issues/27#issuecomment-286041409, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXn_LP5u28UJBzMnrtuZOuIZcJg3Nljks5rlPxNgaJpZM4MYlOg .

jguepin commented 7 years ago

This would be great, maybe we should talk before planning a big refactoring. We still follow most of the rules of https://github.com/airbnb/javascript.

vanwalj commented 7 years ago

Awesome, so we may first add a linter.

We can use eslint and extend the eslint:recommended and airbnb sets of rules

What do you think about that ?

vanwalj commented 7 years ago 
{
    "env": {
        "mocha": true,
        "node": true
    },
    "extends": [
      "airbnb-base"
    ],
    "plugins": [
        "import"
    ]
}

screen shot 2017-03-15 at 16 36 17 🤔

coderofsalvation commented 7 years ago

@vanwalj see https://github.com/lemonwaysas/node-js-client-directkit-json2/issues/2