Update document status to reflect lemonway's api changes - Githubissues

o5r / lemonway

5 stars 2 forks source link

Update document status to reflect lemonway's api changes #64

Closed Naoroy closed 1 year ago

Naoroy commented 1 year ago

Summary

Lemonway's document statuses have changes so we need to update our constants Lemonway's documentation

Closes FC-364.

Changes

lib/constants.js update document status

Related

:warning: https://github.com/o5r/api.october.eu/pull/6588

Up next

N/A.

Real case testing

Using the related PR in api.october.eu

run tests api tests npm run mocha tests/crons/pendingBankUsers They should fail because of your current version of lemonway
link the current version to the dependencies in api.october.eu
- in lemonway's directory: npm link
- in api.october: npm link lemonway
run tests api tests npm run mocha tests/crons/pendingBankUsers again All the tests should pass

Tree

N/A.

Naoroy commented 1 year ago

I'm fine with what you did and how to test it... But from my point of view it's not a real case test as we are using test and we make sure our tests are working.

Also when checking the Lemonway doc or the notion page, I didn't find the new status written somewhere.

Thanks, added a link to the doc in the summary.