search

oGGy990 / certbot-dns-inwx

INWX DNS authenticator plugin for certbot
Apache License 2.0
105 stars 16 forks source link

Add command line switch to control CNAME lookup behaviour #19

Closed akuntsch closed 3 years ago

akuntsch commented 3 years ago

Needed a quick fix to disable the CNAME lookup behaviour even if dnspython is installed (it's installed because another package on my system depends on it) and this is it.

Let me know if you would merge this, then I will edit the README etc. as well.

oGGy990 commented 3 years ago

Hey @akuntsch ,

thanks for sharing your changes.

I'm not opposed to it, but I would prefer to hide the switch if the dnspython dependency is not installed. A default of "true" - or even worse, explicit setting - might be misleading unless an error is thrown later on and a default of "false" breaks with the old behavior. If the switch is simply not there, no false assumptions can be made.

This shouldn't be more than a try catch with the imports around the add() call.

But I'm also open to better arguments. :smile:

akuntsch commented 3 years ago

Hey @oGGy990,

makes sense to me and I don't have a better proposition.

I've updated the commit.

oGGy990 commented 3 years ago

Hey @akuntsch,

thanks for your continued work. :-)

It looks good to me this way.