oJo56 / OOP-Assignment-

1 stars 0 forks source link

Code Review #1

Open AlexBarberLincs opened 1 year ago

AlexBarberLincs commented 1 year ago

At the core level this program works as intended. It doesn't have any specialized random card shuffler, and the output doesn't seem to change.

The code is compact and runs efficiently.

Jacob-Cheadle commented 1 year ago

Jacob Cheadle - 26371737

Commenting

As of yet your code does not contain any comments so I would recommend adding some of these so that anyone reading your code can see what is going on. There is not much else I can comment on regarding your commenting in this case, but this would definitely improve the quality of your code.

Code Functionality

You are missing the 3 different shuffle functions from your code. These should be added. (Fisher-Yates, Riffle, None). Doing this would definitely allow your code to reach a higher level and is a step closer to a functional program.

Future Conciseness

You have used enumeration for enum Suits{ Hearts, Diamonds, Spades, Clubs} which is good however you could do the same with the Ace, King, Queen, Jack and the numbers. This could help finish off your code and make it more efficient than any other methods that you may choose when you eventually reach this part of your code, I can see that you have put these in a list currently however I think being consistent in which method you choose would be good programming practice.

Overall what you have done is a good piece of code but it does lack volume and is not near enough to completion to allow me to run and test it to check for bugs or errors. Once you have completed these fixes and implemented a way to test the code then you can take it further and improve efficiency.