search

oKcerG / SortFilterProxyModel

A nicely exposed QSortFilterProxyModel for QML
MIT License
303 stars 102 forks source link

contribute that to Qt #12

Open tjenssen opened 8 years ago

tjenssen commented 8 years ago

I think this is a big missing API in QML, so I would like to see it at codereview.qt-project.org, I can help to get it in there, if it is needed.

oKcerG commented 8 years ago

It is planned, or at least I thought of it.

But I don't think it's quite ready yet, I'd like it to be field tested before that. I still have some questions about the api and such and I have multiple other convenient features planned.

Contributing to Qt now means I won't be able to explore all the possibilities as easily.

I'll reevaluate in a couple of months, meanwhile I'll get some work done on it.

scgrant327 commented 6 years ago

Kudos! I agree with @tjenssen, this should be a built-in QML API.

PureTryOut commented 4 years ago

@oKcerG 3 and a bit years later, is upstreaming this to Qt still planned?

oKcerG commented 4 years ago

Hello, I think a SortFilterProxyModel addition for Qt would be great. But I don't think mine is a solution worthy to be included. However I've realized some stuff while (not so actively) writing this lib. Inheriting from QSortFilterProxyModel seemed like a good idea at the start and allowed to quickly create a working solution, but it's too high level and not very tunable. It has some shortcoming me and others (notably André Somers from KDAB) have identified. For a more robust base, starting from QAbstractProxyModel would give us more control. But that means a lot of work. Lately I've tried to get my hands dirty on the contributing side of Qt, getting myself involved in code reviews and I've also submitted a couple of small patches (unrelated to SFPM but simple Qt Declarative stuff). If you want to help things move forward, don't hesitate to participate in https://bugreports.qt.io/browse/QTBUG-71348(or in the dev mailing list?) , to share your point of view or possible ideas. I'll be around and would like to participate in what the future of this lib can be.