oSumAtrIX / DownOnSpot

🎧 A Spotify music and playlist downloader working with free Spotify accounts written in Rust
https://osumatrix.me
GNU General Public License v3.0
555 stars 44 forks source link

silent failure to download #12

Closed VincentGijsen closed 10 months ago

VincentGijsen commented 2 years ago

Describe the bug after compilation compilation, it failes silently...
it is compiled, then executing:


Settings successfully loaded.
Continuing with spotify account: <RED>.
Login succeeded.

Nothing happens, no download, am i using it wrong, or is ClientID / Secret to be filled-out, other than standard?

settings:

{
  "username": "<RED>",
  "password": "<RED>",
  "client_id": "client_id",
  "client_secret": "secret",
  "refresh_ui_seconds": 1,
  "downloader": {
    "concurrent_downloads": 4,
    "quality": "Q320",
    "path": "downloads",
    "filename_template": "%artist% - %title%",
    "id3v24": true,
    "convert_to_mp3": false,
    "separator": ", "
  }
}

used brew install lame to get lame mp3 on my system.

To Reproduce

bash-3.2$ ./down_on_spot https://open.spotify.com/playlist/6bYg4fYfP0TNNKpOqLDRSR

Expected behavior a download, progress or failue, instead, jumps straight to terminal

VincentGijsen commented 2 years ago

adding some debug-lines, i have not the error: Error: invalid_client: Invalid client, do i presume correctly that i need a Devaccount from spotify?

edit: adding dev api reqs, solved the issue; guess slight imporvement suggestion is log invalid client_id?,

benjick commented 2 years ago

adding dev api reqs, solved the issue;

How do I get these?

Edit: Here - https://developer.spotify.com/dashboard/applications

VincentGijsen commented 2 years ago

Goto developer.Spotify.com, sign in with your Spotify credentials, create new app, and voilà. It gives you api I’d and key.

Sent from my phone

On 9 Apr 2022, at 23:22, Max Malm @.***> wrote:

 adding dev api reqs, solved the issue;

How do I get these?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

ckcr4lyf commented 10 months ago

Observing the "Silent failure" issue as well, no clear indication in the TUI, and the file is made (.mp3). But it is impossibly small / incomplete.

Kinda related - https://github.com/oSumAtrIX/DownOnSpot/issues/19#issuecomment-1029105723

oSumAtrIX commented 10 months ago

Moving to #53