search

oSumAtrIX / DownOnSpot

🎧 A Spotify music and playlist downloader working with free Spotify accounts written in Rust
https://osumatrix.me
GNU General Public License v3.0
555 stars 44 forks source link

Add argument parser & skip already downloaded songs #14

Open breuerfelix opened 2 years ago

breuerfelix commented 2 years ago

Signed-off-by: Felix Breuer fbreuer@pm.me

oSumAtrIX commented 2 years ago

Can you split this PR so we have a separate PR for the argument parser and skipping downloads? I would like to merge the later

sraka1 commented 2 years ago

@oSumAtrIX is this being worked on?

oSumAtrIX commented 2 years ago

Currently on hold, since I am working on some other projects, you can use the fork though

breuerfelix commented 2 years ago

well it is finished and working, i just do not have the time in splitting this into two seperate PRs i can rebase it though, if you wanna merge it in one PR (it is split into different commits tho)

varac commented 2 years ago

Looking forward to this feature !

mossepso commented 1 year ago

Very useful feature! I will be using the fork for a bit in order to see if it works.

breuerfelix commented 1 year ago

@oSumAtrIX if you plan on merging this, i can rebase and update the branch :) just let me know

oSumAtrIX commented 1 year ago

I forgot to send the requested changes, they were pending for all these months 💀

breuerfelix commented 1 year ago

haha :D the problem is, that this PR is (until today) my first and only touching point with rust... so i am not that good at rust and i also don't know all these best practices or how to implement them. for example, i thought you use the unwrap_or function to set default values. that means, i have no clue on how to do this in another way :D

so: i can rebase this pr but i am not able to implement your changes, maybe someone else can fix them or maybe we can merge my pr to a branch for you as a starting point so you can refactor this a little bit :)