oSumAtrIX / DownOnSpot

🎧 A Spotify music and playlist downloader working with free Spotify accounts written in Rust
https://osumatrix.me
GNU General Public License v3.0
548 stars 45 forks source link

not manage to start download with `down_on_spot.exe` #53

Closed AKtomik closed 7 months ago

AKtomik commented 1 year ago

Hi ! I make the whole instalation uing README guide. The web app is ready, tokens writtens in settings.json (on APPDATA ; im on windows). So, now, i try. Login sucessfull ! Well, cool ! But when I try to add anything more (link), that not working. Like if i just didn't send link, and no more reaction (no message, nor download starting) See : image

So, what's could be wrong ? Its probably a fail on my side, but where ? In the spotify dev app ? Or in the .\down_on_spot.exe link argument syntaxe ? Could you send me just a screen of a working download command ? (search everywhere, but don't find one)

Thank in advance for your help, and thank for your work on this app !

migo1271 commented 1 year ago

Same issue on my side. With latest version nothing happens. Also 0.2.3 is affected. Seems to be a Spotify related problem? Windows 11 with cargo 1.72.0-nightly (03bc66b55 2023-06-23)

AKtomik commented 1 year ago

did you acheeve to make it working before ?

migo1271 commented 1 year ago

Yes, it worked like a charm.

AKtomik commented 1 year ago

Since when its not working ? (time/action/MAJ)

migo1271 commented 1 year ago

I used it the last time in April this year.

oSumAtrIX commented 1 year ago

Currently you need premium. There is an issue with the now deprecated crate aspotify which has ro be replaced with rspotify.

migo1271 commented 1 year ago

Strange. I am using Spotify Premium.

migo1271 commented 1 year ago

I think I found a work-around: remove the /int-xx/ portion in the URL. Then it should work again.

oSumAtrIX commented 1 year ago

Which URL?

AKtomik commented 1 year ago

I think I found a work-around: remove the /int-xx/ portion in the URL. Then it should work again.

Change nothing, and removing portion after the ? too. image

migo1271 commented 1 year ago

You don't need to remove the part after the "?". This doesn't work: down_on_spot.exe https://open.spotify.com/intl-de/track/2fXKyAyPrEa24c6PJyqznF?si=f35a831ebf024ec9 But this does: down_on_spot.exe https://open.spotify.com/track/2fXKyAyPrEa24c6PJyqznF?si=f35a831ebf024ec9 Do you have a premium account? Your link works for me. I can download it (Thaehan - Last Letter).

AKtomik commented 1 year ago

You don't need to remove the part after the "?". This doesn't work: down_on_spot.exe https://open.spotify.com/intl-de/track/2fXKyAyPrEa24c6PJyqznF?si=f35a831ebf024ec9 But this does: down_on_spot.exe https://open.spotify.com/track/2fXKyAyPrEa24c6PJyqznF?si=f35a831ebf024ec9 Do you have a premium account? Your link works for me. I can download it (Thaehan - Last Letter).

Hum, ok. That i do in the last send screenshoot (same link that you say its work for you), but does not work for me. No, i dont have premium, probably for that its does not work on my side (and oSumAtrIX said that its a problem about difference between free and premium, so yep)

oSumAtrIX commented 1 year ago

It's an issue with aspotify as previously explained, you can attach a debugger and step into the code. At some point it where aspotify is used it will just crash. I'm in the middle of migrating to rspotify. The entire codebase needs to be refactored tbh

zilpe commented 12 months ago

@oSumAtrIX Did librespot patch free access? I am simply using free-librespot on it's own and it no longer works. Even applying your modifications to the latest dev branch doesn't work either. Not sure what changed. Potentially sever side? Thanks

oSumAtrIX commented 12 months ago

The one field that I spoofed they spoofed themselves now, the fork is reduntant. I am not sure if additional modifications are currently needed, though currently DownOnSpot fails somewhere along the lines of aspotify from what I have seen, not librespot

zilpe commented 12 months ago

Weird. Because your fork was working in April for me too, but now running it gives the "Premium account required" error.

oSumAtrIX commented 12 months ago

Upstream has made adjustments recently. You should see errors when trying to use librespot. Anyways offtopic

AirOne01 commented 11 months ago

Is it possible that it might be an EOL issue? Because Windows.

oSumAtrIX commented 11 months ago

@AirOne01 Unsure, though one issue is that the crate Spotify is deprecated. I stepped into the code and figured out where the problem was, but no panics whatsoever; the application just exists, and even the debugger can not catch it. I have locally migrated to a superseding crate, but it's not fully done yet.

AirOne01 commented 11 months ago

@oSumAtrIX May be because of the classic "the error is handled" and it's just not.

spotify crate README:

I haven't really worked on this library for a long time, but that's mostly because it's pretty much done. There aren't any significant bugs that I know of and the cli should work just fine.

May be interesting to open a PR with a few tests or explain the issue to the author.

oSumAtrIX commented 11 months ago

My bad, I meant to say the crate "aspotify" not "Spotify".

oSumAtrIX commented 7 months ago

Should be fixed with 388736973582149a33c214f3634bb79644b13736.