search

oUF-wow / oUF

WoW AddOn - Unit frame framework.
MIT License
222 stars 58 forks source link

leaderindicator: Differentiate between leaders and guides #592

Closed ls- closed 2 years ago

ls- commented 3 years ago

It's been a while since these were added, but there's actually 2 types of leaders, guides and leaders, the former are leaders of parties formed via LFD/LFR. In the default UI they use different icons. Also, those UnitIn* checks are unnecessary.

ls- commented 3 years ago

This PR went full circle 😁🔫

Rainrider commented 2 years ago

@ls- do you want to remove default textures next expac or why the compat mode thingy?

ls- commented 2 years ago

@Rainrider I originally wanted to push this stuff during SL, so I added the compat mode thingy, but I decided to delay it until the next xpack, so I'll remove it later on. Also, I don't remember removing those labels, wtf? 🤔

siweia commented 2 years ago

Is it possible to merge LeaderIndicator and AssistantIndicator into one? There shouldn't be someone mark as both roles, right?

ls- commented 2 years ago

Is it possible to merge LeaderIndicator and AssistantIndicator into one? There shouldn't be someone mark as both roles, right?

Given the new functionality of the leader indicator, I'm not sure about that. But I'll review it for the next major. We'll see.

p3lim commented 2 years ago

There shouldn't be someone mark as both roles, right?

You could have both, yes. You can be the leader or an assistant of a normal group and the oposite of an instance group. Although this is a rare situation that I've yet to encounter myself, and I doubt there's any point in supporting it.

ls- commented 2 years ago

Merged into #613.