oUF-wow / oUF

WoW AddOn - Unit frame framework.
MIT License
221 stars 58 forks source link

core: Fix contextual ping on header children #661

Closed p3lim closed 10 months ago

p3lim commented 10 months ago

When header children spawn during combat (e.g. a raid member joins) it would throw an error because we can't set attributes then.

Moving the attribute setter into a non-header block plus initialConfigFunction solves this, while we gotta keep the Mixin call where it was as the Mixin function nor the arg we pass through it exists in a secure environment.

Ref https://github.com/oUF-wow/oUF/pull/659#discussion_r1375492483

Meivyn commented 10 months ago

Confirm that this fixed the issue. Thanks for addressing it.