oVirt / ovirt-ansible-collection

Ansible collection with official oVirt modules and roles
72 stars 91 forks source link

Support boot disk renaming and resizing. #705

Closed mmartinv closed 1 year ago

mmartinv commented 1 year ago

Renames the boot disk when the boot_disk_name variable is defined within the profile or the VM properties. (The latter has precedence over the former). The VM disk must have the bootable flag set.

By default, if boot_disk_name is defined, the VM name will be prepended to the boot disk name so the final name would be:

{{ vm_name }}_{{ boot_disk_name }}

This behavior can be disabled by setting the variable boot_disk_use_vm_name_prefix to false. In this case the final name of the boot disk will be the value of boot_disk_name.

The boot disk can also be resized by defining the boot_disk_size variable.

The value can contain a suffix that complies to the IEC 60027-2 standard (for example 10GiB, 1024MiB)

Signed-off-by: Miguel Martín mmartinv@redhat.com

mmartinv commented 1 year ago

Generally looks good, even though I don't see the use case.

Renaming the disks is useful because, right now, the template disk name is maintained so if a lot of VMs are created from a template there will be a lot of disks with the same name.

Resizing the boot disks allows the VMs based on a cloud-init template to have an arbitrary root disk size (The ovirt disk is resized by the role and cloud-init resizes the partition and the filesystem size in the first boot.

But we need to agree if i's major or minor change from the point of the release version number

I personally don't mind, let's see what @mnecas has to say.