search

oVirt / ovirt-ansible-collection

Ansible collection with official oVirt modules and roles
72 stars 89 forks source link

Not possible to attach LUN to running VM through ansible #736

Open saksham-oracle opened 8 months ago

saksham-oracle commented 8 months ago

Issue: Ansible example shows that lun can be attached to vm. The example shows to add lun with lun_id and storage_type attribute. The ansibles scripts fails to execute as it fails to attach disk because it failed to find the lun and associated disk info. The issue was the lun directory structure has lun_id attribute and the lookup code was using just id instead of lun_id.

https://docs.ansible.com/ansible/latest/collections/ovirt/ovirt/ovirt_disk_module.html#parameter-logical_unit/lun_id

Fix: Fix the attribute name that used to get the disk info.

Signed-off-by: Saksham Srivastava saksham.sa.srivastava@oracle.com

mnecas commented 7 months ago

Hi @saksham-oracle thank you for the MR, checked out the other places and rather would align the documentation than the code. Posted the fix