search

oVirt / ovirt-engine-api-model

oVirt Engine API Model
19 stars 33 forks source link

Add missing DisplayType values #102

Open dupondje opened 1 year ago

dupondje commented 1 year ago

In org.ovirt.engine.core.common.businessentities.DisplayType we have the supported DisplayType's. The API Model DisplayType values do not match these values.

The ovirt-engine code contains code to map VNC and SPICE DisplayType from the API to the businessentities.DisplayType values, but never were the real values added to the API Model.

In this commit we deprecate the 'legacy' DisplayType's in favor of the real DisplayType's.

Change-Id: Ibc9d7cbec88effd62172983da6ab705160ad8879

sandrobonazzola commented 1 year ago

@dupondje can you move the CI fix to its own PR? Looks like the build is not running at all

dupondje commented 1 year ago

Done: https://github.com/oVirt/ovirt-engine-api-model/pull/103

dupondje commented 1 year ago

This was needed to bulk-change a bunch of VM's to VGA-VNC prior to migration to CentOS 9 (Where QXL/SPICE is removed)

dupondje commented 1 year ago

Any chance this can get merged/reviewed? :)

sgratch commented 11 months ago

Any chance this can get merged/reviewed? :)

Please check my comment above https://github.com/oVirt/ovirt-engine-api-model/pull/102#discussion_r1384802388