search

oVirt / ovirt-engine-api-model

oVirt Engine API Model
19 stars 33 forks source link

Changed type of Display.disconnectActionDelay() to Short #49

Closed smelamud closed 2 years ago

smelamud commented 2 years ago

Change-Id: Ib1e58452f24f96acf85badcc6450ef53944eef1d Signed-off-by: Shmuel Melamud smelamud@redhat.com

oliel commented 2 years ago

what is the reason for this change?

smelamud commented 2 years ago

what is the reason for this change?

This should fix the bug https://bugzilla.redhat.com/show_bug.cgi?id=2076053 The disconnect delay value in the Engine is short and specifying a larger value causes overflow. And there is no reason for allowing larger values in the Engine - maximum delay of ~9 hours is more than enough.

liranr23 commented 2 years ago

Based on Shmuel answer above, LGTM

Just saying, better to mention this on the commit.