search

oVirt / ovirt-engine-sdk-go

The generator of Go SDK for oVirt v4.0+
Apache License 2.0
19 stars 23 forks source link

Missing interfaces #199

Closed pkliczewski closed 3 years ago

pkliczewski commented 4 years ago

The problem

In order to write tests to make sure that the sdk worked in the context of the code it was written in it is needed to create interfaces. This should be part of this repo.

Environment

Please take a look here.

Steps to Reproduce

  1. Try to write tests for the code which uses this sdk and mock different responses.
sandrobonazzola commented 4 years ago

@pkliczewski did #1042 fix this issue? @imjoey ?

ghost commented 3 years ago

Hey folks, as we pick old issues, no I do not believe that this issue has ever been fixed.

In the absence of a PR to resolve this issue at the root I would recommend taking a look at the go-ovirt-client overlay, which attempts to provide a friendlier API to oVirt using this library as a backend, as well as a built-in mock facility. However, it only contains a partial implementation that is extended on an as-needed basis. (PRs are most welcome.)

ghost commented 3 years ago

@pkliczewski I'm closing this issue as we agreed that it'd better to use go-ovirt-client for your purposes. Anyone else: feel free to reopen or file a new issue if this is still needed.