oVirt / ovirt-engine-sdk-ruby

Ruby gem that simplyfies access to the oVirt Engine API
20 stars 13 forks source link

Update to Ruby 3 #10

Open jhernand opened 9 months ago

jhernand commented 9 months ago

Currently the SDK doesn't build or work with Ruby 3:

This patch contains fixes for all those issues.

jhernand commented 9 months ago

Not that this will also need a new version of the API metamodel containing this change: https://github.com/oVirt/ovirt-engine-api-metamodel/pull/34

kbrock commented 2 months ago

Would it be easier to merge if we split this PR apart? e.g.: the rubocop changes seem like a no brainer

Or is the issue that there just isn't much time and multiple PRs are actually more difficult?

kbrock commented 2 months ago

I pulled the c code fix and put into #17 (kept attribution)

kbrock commented 2 months ago

@sandrobonazzola FYI - your commit does not have signoff

sandrobonazzola commented 2 months ago

@sandrobonazzola FYI - your commit does not have signoff

I just hit rebase :-) @jhernand / @eremeyev can you fix commit message with missing sign off?

mwperina commented 2 months ago

The problem with this change is, that weld 3 super hard to package as RPM due to missing dependencies, that's why we are still using weld 2.y. If we merge this PR before weld 3.y is available as RPM on cbs.centos.org, build process will be completely broken:

https://cbs.centos.org/koji/packageinfo?packageID=8971

kbrock commented 2 months ago

@mwperina thank you

Can we take the weld changes out of here? (and put into another PR) So this would be mergable?

UPDATE: I created #19 which contains the ruby changes but not the Weld changes Any little bit of progress is still progress