search

oVirt / ovirt-engine-sdk-ruby

Ruby gem that simplyfies access to the oVirt Engine API
20 stars 13 forks source link

update signature for hash_foreach value #17

Closed kbrock closed 2 months ago

kbrock commented 2 months ago

Resolves one issue in #14

Change

Updated c files to fix warnings (that prevent this from building on a mac and linux machine)

Before

gem install ovirt-engine-sdk -v4.6.0
# fail

gem install --verbose ovirt-engine-sdk -v4.6.0 -- --with-cflags="-Wno-error=incompatible-function-pointer-types -Wno-error=implicit-function-declaration"
# succeed

After

(hopefully. I can't do this since I can't push the changes)

gem install ovirt-engine-sdk -v4.6.0

@sunpoet This is your code change from freebsd. If this gets merged, you will be able to remove it from your custom patch. Is it ok to apply here? Thnx

If you want me to add attribution and signoff for you, or if you'd prefer creating your own PR. Please let me know.

UPDATE: contact with author and signed off

--

@jhernand I pulled out your c change from #10 - I feel the gemspec changes are probably also needed, but trying to keep this as minimal as possible.

I left your signoff for the partial commit, please let me know if you agree or feel this does not properly reflect your intent.

@sandrobonazzola I noticed your commit does not have a Signoff. Please advise

kbrock commented 2 months ago

I can pull just my own commits out into a separate PR (since it is signed off) if you would like.

sunpoet commented 2 months ago

@sunpoet This is your code change from freebsd. If this gets merged, you will be able to remove it from your custom patch. Is it ok to apply here? Thnx

If you want me to add attribution and signoff for you, or if you'd prefer creating your own PR. Please let me know.

Thanks for handling this. Please feel free to use that patch. It'll be great if the fix is merged upstream.