search

oVirt / ovirt-engine

The oVirt Engine virtualization manager
Other
519 stars 270 forks source link

Sub-Version Name length is not validated #777

Open ljelinkova opened 1 year ago

ljelinkova commented 1 year ago

PR https://github.com/oVirt/ovirt-engine/pull/771 revealed that the validations of the template names are not correct - the template name was validated to be max length of 40 characters whereas it is Sub-Version Name that should be validated both in frontend and backend as the database field is set to character varying(40).

ljelinkova commented 1 year ago

As @ahadas pointed out in https://github.com/oVirt/ovirt-engine/pull/771#issuecomment-1345580819, there is no real reason to limit the Sub-Template name to 40 characters. Would it make sense to change the database to allow longer text? Maybe the same as the vm_name that is character varying(255)?