oVirt / ovirt-engine

The oVirt Engine virtualization manager
Other
513 stars 268 forks source link

Change save/restore nvram data logic #886

Closed antonios-f closed 1 year ago

antonios-f commented 1 year ago

Save NVRAM data not only if BiosType is Q35_SECURE_BOOT Also save if Q35_OVMF because it also includes EFI boot variables With Q35_OVMF we unable to boot non-fallback bootloaders in place different from /EFI/BOOT/BOOT.EFI

To check this it needed to: 1) Run VM with installed Linux (it doesn't matter what distro) 2) Add a bootloader via efibbotmgr efibootmgr -c -d -L "Some Linux" -l \EFI\\grubx64.efi 3) Look at created efi boot variable efibootmgr -v It's present 4) Shutdown or Poweroff VM 5) Run it again 6) Check efi boot variables again efibootmgr -v It's absent 7) We got non bootable VM if fallback bootloader is broken or boot default esp/EFI/BOOT/BOOT.EFI otherwise