Force LC_ALL=C before running df -l command on pki-enroll-request

oVirt / ovirt-engine

The oVirt Engine virtualization manager

Other

493 stars 259 forks source link

Force LC_ALL=C before running df -l command on pki-enroll-request #891

Closed nkovacne closed 7 months ago

nkovacne commented 7 months ago

Changes introduced with this PR

pki-enroll-request.sh checks if the CA file is stored on a local filesystem. However, the 'df' command output depends on the local system language, thus output may vary. With this patch LANG=C is forced just before the 'df' command is run.

Are you the owner of the code you are sending in, or do you have permission of the owner?

Yes.

didib commented 7 months ago

LGTM. Please handle the DCO failure - add a 'Signed-off-by:' line to your commits. And perhaps squash to a single commit.

nkovacne commented 7 months ago

LGTM. Please handle the DCO failure - add a 'Signed-off-by:' line to your commits. And perhaps squash to a single commit.

Removed the useless commit, and added the Signed-off-by line to the rebased commit.

didib commented 7 months ago

Sorry, github insists on using the same "real name" in both the "Author" (and perhaps Commit) fields and in the "Signed-off-by" line. For former you have "Nicolás Kovac Neumann" but for latter you dropped "Neumann". See:

https://github.com/oVirt/ovirt-engine/pull/891/checks?check_run_id=18697876068

Please fix, thanks...

didib commented 7 months ago

Thanks!