During VM import from SD, exclude shared disk when iterating over disk snapshots

shubhaOracle commented 6 months ago

Changes introduced with this PR

Issue: When importing VM from SD, if VM has snapshot/s and a shared disk attached, a blank snapshot is created upon import.

Steps to reproduce:

Create a shared disk and attach to VM1 and VM2
Create a snapshot snap-1 for both VMs respectively
Detach the SD that has disks for these VMs
Attach the SD and make sure VM1 and VM2 are listed under VM import.
Import VM1. You will see a blank snapshot created under 'Snpashots' tab. Pl see screenshot below
Import VM2, will fail with error - "2023-12-13 18:37:10,426-05 ERROR [org.ovirt.engine.core.bll.exportimport.ImportVmFromConfigurationCommand] (EE-ManagedThreadFactory-engine-Thread-18176) [a75c5669-6676-4d7d-ab3d-aace0d938d5e] Command 'org.ovirt.engine.core.bll.exportimport.ImportVmFromConfigurationCommand' failed: CallableStatementCallback; SQL [{call insertsnapshot(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)}]; ERROR: duplicate key value violates unique constraint "pk_snapshots""

The issue happens since shared disk is considered as snapshot the during import and entry is added to the snapshots table

Are you the owner of the code you are sending in, or do you have permission of the owner?

[y/n] n

Signed-off-by: Shubha Kulkarni shubha.kulkarni@oracle.com

shubhaOracle commented 3 months ago

Requesting Reviews

shubhaOracle commented 3 months ago

Requesting Reviews/Approval

shubhaOracle commented 3 months ago

Requesting Reviews/Approval

sandrobonazzola commented 1 month ago

Merging based on previous approval