search

oVirt / ovirt-engine

The oVirt Engine virtualization manager
Other
492 stars 259 forks source link

"secure boot" not getting enabled for Chipset/Firmware Type "Q35 Chipset with UEFI SecureBoot" #912

Open saksham-oracle opened 5 months ago

saksham-oracle commented 5 months ago

Issue: When VM emulator is changed to Q35 Chipset with UEFI SecureBoot from Q35 Chipset with UEFI, the NVRAM file needs to be rewritten.

Fix: On VM update remove the previous NVRAM file.

Signed-off-by: Saksham Srivastava saksham.sa.srivastava@oracle.com

smelamud commented 3 months ago

This change seems to be an addition to #887. That PR puts a new condition here: IF (OLD.bios_type = 4 AND NEW.bios_type != 4) OR (OLD.bios_type = 3 AND NEW.bios_type < 3) THEN. It is possible to change it to IF (OLD.bios_type = 4 AND NEW.bios_type != 4) OR (OLD.bios_type = 3 AND NEW.bios_type != 3) THEN to include this case also.