search

oVirt / ovirt-engine

The oVirt Engine virtualization manager
Other
492 stars 259 forks source link

Issue: Incorrect Data Center for the "Upload Image" dialog #923

Open sermakov-orion opened 4 months ago

sermakov-orion commented 4 months ago

Signed-off-by: Stepan Ermakov sermakov@orionsoft.ru

Changes introduced with this PR

This PR fixes the following issue: incorrect Data Center is displayed when uploading a disk image from "Storage Domain Disks" UI. Steps to reproduce:

  1. Create a Storage Domain at a non-Default Data Center.
  2. Open the Storage -> Domains -> [The created Storage Domain] -> Disks page.
  3. Select the Upload -> Start menu item. The "Upload image" dialog is displayed.

Expected behavior: The Data Center field is disabled and displays the name of the non-Default Data Center. Current behavior: The Data Center field is disabled and displays the name of the Default Data Center.

Fixed in the following way: when "Upload image" dialog is displayed then query the Storage Domain details with information about its Data Center and select the Storage Domain's Data Center in the "Data Center" field

Are you the owner of the code you are sending in, or do you have permission of the owner?

y

sermakov-orion commented 3 months ago

Requesting Reviews.

barpavel commented 1 month ago

LGTM.