search

oVirt / ovirt-engine

The oVirt Engine virtualization manager
Other
492 stars 259 forks source link

Skip chmod of ENGINE_EXTERNAL_PROVIDERS_TRUST_STORE in DEVELOPER_MODE #926

Closed dupondje closed 3 months ago

dupondje commented 3 months ago

The keytool command before this _set_file_permissions is not executed in DEVELOPER_MODE. If we execute the chmod, it fails with: Failed to execute stage 'Misc configuration': [Errno 2] No such file or directory: '/home/xxx/xxx/var/lib/ovirt-engine/external_truststore' as the file was not created.

didib commented 3 months ago

Looks good to me. No idea if and how much the ovn plugin was tested/used in developer-mode - I know I didn't ever try it myself (and hardly ever used developer-mode otherwise, I admit - I always tested stuff on separate VMs, not on my main machine).

didib commented 3 months ago

You might want to add an 'else:' with output to the developer to say what should be done in developer-mode, if any, or at least mention that the chmod was skipped.

didib commented 3 months ago

Merging anyway. Thanks!

dupondje commented 3 months ago

Looks good to me. No idea if and how much the ovn plugin was tested/used in developer-mode - I know I didn't ever try it myself (and hardly ever used developer-mode otherwise, I admit - I always tested stuff on separate VMs, not on my main machine).

We are working on a docker dev container for oVirt, so it's easier for new dev's to start working on oVirt without the need of an external VM. So that's the reason I've hit it :)

didib commented 3 months ago

10 years ago Moran spent some time on https://github.com/mgoldboi/oVirt-Dockerized. No idea what its state, but it was eventually neglected. Good luck!