fix: SerializationException: Type 'org.ovirt.engine.core.common.utils.SecretValue' was not included in the set of types... #900

oVirt / ovirt-engine

The oVirt Engine virtualization manager

Other

513 stars 268 forks source link

fix: SerializationException: Type 'org.ovirt.engine.core.common.utils.SecretValue' was not included in the set of types... #900 #956

Open sermakov-orion opened 2 months ago

sermakov-orion commented 2 months ago

Fixes issue

This PR fixes the https://github.com/oVirt/ovirt-engine/issues/900 issue.

Changes introduced with this PR

Since the SecretValue structure is used in GWT, it should implement Serializable interface. Also couple null checks were added to avoid NPE in the scenario explained in the #900 issue.

Are you the owner of the code you are sending in, or do you have permission of the owner?

Yes

sermakov-orion commented 2 months ago

Requesting Reviews.