search

oVirt / ovirt-engine

The oVirt Engine virtualization manager
Other
519 stars 271 forks source link

bll/storage: don't check source domain space on lsm #968

Open dupondje opened 1 month ago

dupondje commented 1 month ago

When doing a LiveStorageMigration, the code checked if the disk/image would fit not only on the destination, but also on the source. This because theoretically the snapshot image can grow until the disksize.

But this means that we needed to live migrate a 1TB disk, also at least 1TB of free space on the source domain. This is quite useless, and causes problemns to move disks from for example an already overloaded source domain.

As this check is neither being done when creating a simple snapshot, just drop the check on the source domain.

Are you the owner of the code you are sending in, or do you have permission of the owner?

[y]

sandrobonazzola commented 1 month ago

@sermakov-orion , @saksham-oracle can you please review?