search

oVirt / ovirt-imageio

The oVirt image transfer daemon and clients.
GNU General Public License v2.0
20 stars 24 forks source link

Tests fail with python 3.6 on Fedora 37 #184

Open nirs opened 1 year ago

nirs commented 1 year ago

To reproduce:

================================================= test session starts ==================================================
platform linux -- Python 3.6.15, pytest-7.0.1, pluggy-1.0.0
cachedir: .tox/test-py36/.pytest_cache
rootdir: /home/nsoffer/src/ovirt-imageio, configfile: tox.ini
plugins: timeout-2.1.0, cov-4.0.0
timeout: 30.0s
timeout method: thread
timeout func_only: False
collected 1670 items / 1 error / 22 deselected / 1647 selected                                                         

======================================================== ERRORS ========================================================
__________________________________________ ERROR collecting test/http_test.py __________________________________________
test/http_test.py:1143: in <module>
    "address", [a[4][0] for a in http.find_addresses(socket.gethostname())])
test/http_test.py:1143: in <listcomp>
    "address", [a[4][0] for a in http.find_addresses(socket.gethostname())])
ovirt_imageio/_internal/http.py:860: in find_addresses
    address = ipaddress.ip_address(ai[4][0])
/usr/lib64/python3.6/ipaddress.py:54: in ip_address
    address)
E   ValueError: 'fe80::1123:81d2:7ad2:15e3%enp9s0u2u1u2' does not appear to be an IPv4 or IPv6 address
nirs commented 1 year ago

Tested also python3.9 and python3.10 on Fedora 37. In the first build I forgot to install the python3*-devel package and both had some test failures.

I could not find python3.9-devel but after installing python3.10-devel all tests passed in both versions.

Seems that we need clear documentation on how to test with multiple python version.