search

oVirt / ovirt-jenkins-plugin

Jenkins plugin to run agents using oVirt
3 stars 2 forks source link

Review ovirt-slaves-plugin code and check if its a good starting point for this #6

Open ifireball opened 5 years ago

ifireball commented 5 years ago

https://github.com/thescouser89/ovirt-slaves-plugin

danielBelenky commented 5 years ago

I've reviewed the plugin you've mentioned just before opening this repo. It seems like that plugin was not maintained for a long time. Other than that, the use case of that plugin is different than what we are trying to achieve here. The mentioned plugin allows a definition of static slaves with oVirt VM backing them up. What we want to achieve in this plugin at first, is ephemeral VMs as Jenkins slaves.

Usually, I'd prefer to start from the already existing code base, but since the use cases are very different, I'm afraid that forking that plugin and refactoring will take longer than writing our own implementation.

conradjones commented 4 years ago

I've fixed the compile errors with the existing one if it helps anyone