search

oVirt / ovirt-openshift-extensions

Implementation of flexvolume driver and provisioner for oVirt
Apache License 2.0
31 stars 16 forks source link

Fixed StorageType for FibreChannel Storagedomain #131

Closed alclonky closed 5 years ago

alclonky commented 5 years ago

ovirt-api: the Storage type for fibrechannel is fcp not fc see: http://ovirt.github.io/ovirt-engine-api-model/4.2/#types/storage_type

MOTIVATION \ I am getting the Error: 2019-04-03 13:59:24,829+02 WARN [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-19991) [bcf73cb0-3a27-447e-b093-0dc3bf0ff15e] Validation of action 'AddDisk' failed for user -authz. Reasons: VARACTIONADD,VARTYPEDISK,ACTION_TYPE_FAILED_DISK_CONFIGURATION_NOT_SUPPORTED,$volumeFormat RAW,$volumeType Sparse 2019-04-03 13:59:24,835+02 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default task-19991) [] Operation Failed: [Cannot add Virtual Disk. Disk configuration (RAW Sparse) is incompatible with the storage domain type.]

MODIFICATION \ fixed type, see api documentation

RESULT \ hope that fixes my problem?

ovirt-infra commented 5 years ago

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project. As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.
rgolangh commented 5 years ago

Oh what a stupid mistake. Thanks a lot for posting!

rgolangh commented 5 years ago

ci test please

alclonky commented 5 years ago

let me know when there is a build to test

rgolangh commented 5 years ago

ci build please

alclonky commented 5 years ago

With this build I got it running. Thx