search

oVirt / ovirt-openshift-extensions

Implementation of flexvolume driver and provisioner for oVirt
Apache License 2.0
31 stars 16 forks source link

Allow injection of credentials via K8s secrets #145

Closed Timoses closed 2 years ago

Timoses commented 5 years ago

flex|provisioner|cloud-provider|ovirt-api|ci : Short imperative summary

MOTIVATION \ Credentials should not be written directly to ConfigMaps. Instead Secrets should be used.

MODIFICATION \ This PR implements injection of credentials via a credential's file (specified via OVIRT_CONNECTION_CREDENTIAL_FILE environment variable) or directly via environment variables (OVIRT_CONNECTION_USERNAME and OVIRT_CONNECTION_PASSWORD).

RESULT \ K8s secrets can now be injected into the ovirt containers.

Fixes: https://github.com/oVirt/ovirt-openshift-extensions/issues/138

Changes not yet tested!

ovirt-infra commented 5 years ago

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project. As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.
Timoses commented 5 years ago

@rgolangh Tested it now. Both variants (file and username/password ENV vars) work.

Please let me know if anything should be adjusted.

sandrobonazzola commented 2 years ago

This project is no longer maintained, closing.