oVirt / ovirt-site

oVirt website
http://www.ovirt.org/
Other
87 stars 289 forks source link

The names there are crossed out on community page #15

Closed david-caro closed 8 years ago

david-caro commented 8 years ago

at http://beta-ovirtweb.rhcloud.com/community/

garrett commented 8 years ago

Yep. That's a debugging style to show that the link no longer works for special wiki pages. It should be disabled before the site is published live.

It's defined as .broken-link in line 182 of site.sass.

https://github.com/oVirt/ovirt-site/blob/master/source/stylesheets/lib/site.sass#L182-L186

This is intentional, to make those non-working links highly visible. Someone needs to go through all the documents and fix the content.

garrett commented 8 years ago

Here's a list of all resulting pages:

Most are linking to "user:" pages, which do not exist. Some are linking to "special:" pages, which also do not exist (as this is not MediaWiki).

garrett commented 8 years ago

I can modify the code that produces the error to silently ignore user pages. It would then not link to anything, but still show the text of the link (that is, the name of the person). For the case of the Special pages, those need to be edited in the source.

There are 706 pages that refer to "user:", so having it automated would probably be preferable.

There are 4 documents that link to "special:" pages. These source docs need hand-editing to remove the links. The source files for these 4 are:

The documentation for these 4 pages probably need to be revised anyway, as I'm certain that each one of them refers to wiki-related stuff (else they wouldn't have wiki links).

thatdocslady commented 8 years ago

@eedri I think this is what you were talking about?

eedri commented 8 years ago

@thatdocslady yes

garrett commented 8 years ago

This looks fixed. Closing bug.