Replace secret data with asterisks in debug logs

oVirt / vdsm-jsonrpc-java

JSON RPC Java client for oVirt

8 stars 11 forks source link

Replace secret data with asterisks in debug logs #24

Closed mz-pdm closed 2 years ago

mz-pdm commented 2 years ago

Vdsm provides secret data, namely TPM and secure boot NVRAM data, to Engine in response to getVmExternalData API call. This data is returned with ‘_X_data’ key and occurs in debug logs. When logging an API call response, let’s replace data of ‘X*’ keys with asterisks.

mz-pdm commented 2 years ago

/ost

mz-pdm commented 2 years ago

/ci

mz-pdm commented 2 years ago

@mwperina , what to do with this, merge or abandon?