oVirt / vdsm-jsonrpc-java

JSON RPC Java client for oVirt
8 stars 11 forks source link

Disconnect the session after SSL handshake issue #28

Closed dupondje closed 1 year ago

dupondje commented 1 year ago

When the handshake check that is added in PR #17 fails, then a ClientConnectionException is thrown, and passed up to the client in ovirt-engine. But as the connection is in some invalid state, but not disconnected, it for example causes there are no heartbeats anymore.

This fix also closes the connection when there is some ClientConnectionException in the postConnect stage.

This should fix #27

sandrobonazzola commented 1 year ago

/ost

michalskrivanek commented 1 year ago

it's a risky change. but we always had some mysterious situations when host monitoring stopped for no obvious reason. i'd be in favor of merging it. worst case we'll revert...

mwperina commented 1 year ago

/ost

mwperina commented 1 year ago

/ost