search

oVirt / vdsm

The Virtual Desktop Server Manager
GNU General Public License v2.0
160 stars 201 forks source link

Backport: lvmdevices: always create devices file #336

Closed aesteve-rh closed 1 year ago

aesteve-rh commented 1 year ago

Create empty devices file even if no lvm volumes are found with vdsm-tool config-lvm-filter.

Otherwise configuring LVM to use a devices file without the file allows lvm commands to see all volumes, with the associated risk.

Bug-Url: https://bugzilla.redhat.com/2125290 Signed-off-by: Albert Esteve aesteve@redhat.com

aesteve-rh commented 1 year ago

@michalskrivanek Apparently we also need to update the expected jobs for the ovirt-4.5.3.z branch. Could you change the project settings (again) for this branch? Thanks!

:red_circle: test-storage -> :green_circle: test-storage-user and :green_circle: test-storage-root :red_circle: rpm -> :green_circle: el8 and :green_circle: el9

michalskrivanek commented 1 year ago

no, they're different (look at expected jobs). unless we backport those el9 changes - and i do not see why we would - we just need the build jobs and the "previous" version of test-storage-*

michalskrivanek commented 1 year ago

...ready

mz-pdm commented 1 year ago

/ost

aesteve-rh commented 1 year ago

/ost

michalskrivanek commented 1 year ago

Note OST is not configured on branches. Master is enough. It will get tested on rhel8 runs once it reaches rhv