oVirt / vdsm

The Virtual Desktop Server Manager
GNU General Public License v2.0
160 stars 201 forks source link

ci/container.yml: build also vdsm-test containers #337

Closed aesteve-rh closed 1 year ago

aesteve-rh commented 1 year ago

Build also vdsm test containers in the weekly build workflow.

Add another job to the containers workflow to build and upload test containers in docker directory.

For test containers, build each distro separately and push it to the same repository with a different tag.

Final tree of Vdsm repositories:

.
└── ovirt/
    ├── ovirt-vdsm-network-tests-functional:
    │   ├── centos-8
    │   ├── centos-9
    │   └── alma-9
    ├── ovirt-vdsm-network-tests-integration:
    │   ├── centos-8
    │   ├── centos-9
    │   └── alma-9
    ├── ovirt-vdsm-network-tests-unit:
    │   ├── centos-8
    │   ├── centos-9
    │   └── alma-9
    └── ovirt-test:
        ├── centos-8
        ├── centos-9
        └── alma-9

Signed-off-by: Albert Esteve aesteve@redhat.com

aesteve-rh commented 1 year ago

I was thinking how to unify strategies, and in the end I think this may be the best option:

It follows a distro:version scheme for container names, which feels more natural. All of them can share the same targets in the makefile (i.e., [ centos-8, centos-9, alma-9 ]), it would only require a small update in the network makefile to change the target and the type variables; and would still keep the network containers grouped, so the number of repositories in quay will not explode.

This will make the workflow update easier.

What do you think? @tinez @nirs @almusil

Back one step, due to recent changes in ovirt-imageio (that already uses a single repository for tests, with distro as tag).

aesteve-rh commented 1 year ago

Already created the repository: https://quay.io/repository/ovirt/vdsm-test