search

oVirt / vdsm

The Virtual Desktop Server Manager
GNU General Public License v2.0
160 stars 201 forks source link

Fix missing informations on geo replication tab of GlusterFS volumes. #340

Closed yasalos closed 1 year ago

yasalos commented 1 year ago

Since the upgrade to oVirt 4.5 and GlusterFS 10, information about snapshots and geo replication are no more visible on the engine Webui. After digging VDSM logs, I found that it's caused by the change of some XML elements name introduced in a new Gluster release (https://github.com/gluster/glusterfs/pull/1568) and by the addition of the timezone in output of status command.

This commit fix the parsing process of the output returned by gluster command, so that data sent to ovirt engine are as expected.

Bug-URL: https://bugzilla.redhat.com/show_bug.cgi?id=2104278

yasalos commented 1 year ago

OK, i'll update the code so that both version are supported.

yasalos commented 1 year ago

I updated the code to make sure that both (old and new) format of XML output are supported.

mz-pdm commented 1 year ago

Some more errors from the linter (see the CI failures -- too long lines).

yasalos commented 1 year ago

Some more errors from the linter (see the CI failures -- too long lines).

Fixed

mz-pdm commented 1 year ago

Great, CI and I are happy now. Let's see whether OST is happy too, as well as Albert about the formatting :-).

mz-pdm commented 1 year ago

/ost

mz-pdm commented 1 year ago

/ost

mz-pdm commented 1 year ago

Although not reported here for whatever reason, OST actually ran and succeeded.

mz-pdm commented 1 year ago

Congratulations to completing your first contribution!

yasalos commented 1 year ago

Congratulations to completing your first contribution!

It was not just my first contribution to oVirt, but to any project. I want to thank, both Albert and you for leading the way and helping me during this process. Now, I have to go and read the new contributors guidelines section in development.md file ;-)