oVirt / vdsm

The Virtual Desktop Server Manager
GNU General Public License v2.0
160 stars 201 forks source link

Remove SPDX headers from sensitive files #341

Closed mz-pdm closed 1 year ago

mz-pdm commented 1 year ago

The recently added SPDX headers cause some problems with downstream builds:

Let’s remove SPDX headers from the given places to avoid false alerts. Let’s also disable ‘reuse’ check in ‘make lint’ to avoid linter failures due to missing SPDX headers.

This is 4.5.3-only change to avoid problems with downstream builds.

aesteve-rh commented 1 year ago

Rather than disabling the reuse linter, we should've used explicit licenses (i.e., create files with .license extension, which allows keeping files without SPDX header, and still makes the linter happy).

$ contrib/add-spdx-header.sh --explicit-license \
    static/etc/sudoers.d/50_vdsm.in \
    static/usr/share/vdsm/autounattend/Autounattend.xml.in \
    vdsm_hooks/extra_ipv4_addrs/sudoers \
    vdsm_hooks/localdisk/sudoers.vdsm_hook_localdisk \
    vdsm_hooks/openstacknet/sudoers.in \
    vdsm_hooks/vhostmd/sudoers.vdsm_hook_vhostmd
mz-pdm commented 1 year ago

This fix/merge was quick because we needed it to proceed with the build. It might be worth to backport the XML fix from master and add the explicit licenses as you suggest for the sudoers files. I'll post a PR for that.