oVirt / vdsm

The Virtual Desktop Server Manager
GNU General Public License v2.0
160 stars 201 forks source link

github actions: upgrade to checkout version 3 #376

Closed erav closed 1 year ago

erav commented 1 year ago

Version 2 of the checkout action produces a warning and cancels the action. Upgrading to version 3.

Change-Id: I6f80aeae400104a188615444ca3bdbbcc8817898 Signed-off-by: Eitan Raviv eraviv@redhat.com

aesteve-rh commented 1 year ago

Where did you see the warning? I have briefly checked the latest Actions and couldn't find it.

erav commented 1 year ago

for example here: https://github.com/oVirt/vdsm/actions/runs/4154350915

image

aesteve-rh commented 1 year ago

There is a warning for the checkout, but it does not seem to cause the Action to cancel. AFAIU seems to be the podman run command that fails:

Storing signatures
time="2023-02-12T02:50:53Z" level=error msg="Updating image \"44b33053e96b60856ac33e46acff3358db2bdac20da1b5beb0a6dcc9b7a1f0df\" (old names []) failed, deleting it"
time="2023-02-12T02:50:53Z" level=error msg="Error deleting incomplete image \"44b33053e96b60856ac33e46acff3358db2bdac20da1b5beb0a6dcc9b7a1f0df\": identifier is not an image"
Error: 2 errors occurred while pulling:
 * initializing source docker://ovirt/vdsm-network-tests-integration:centos-8: reading manifest centos-8 in docker.io/ovirt/vdsm-network-tests-integration: errors:
denied: requested access to the resource is denied
unauthorized: authentication required

 * committing the finished image: setting names [quay.io/ovirt/vdsm-network-tests-integration:centos-8] on image "44b33053e96b60856ac33e46acff3358db2bdac20da1b5beb0a6dcc9b7a1f0df": layer not known
+ CONTAINER_ID=
erav commented 1 year ago

added fail-fast:false to network.yml . Functional tests have been having issues since a long time. We have even skipped them on centos-9. Now they are failing on centos-8 and alma-9 as well. Solving them on this PR is out of scope and would just delay it indefinitely. So let's merge this PR so the real issues can be addressed more easily

erav commented 1 year ago

@sandrobonazzola could you please have a look? Looks like checkout@v3 mutes the warnings which helps in reducing the noise.

erav commented 1 year ago

@sandrobonazzola can you please merge if you approve? I don't have permissions... thanks