search

oVirt / vdsm

The Virtual Desktop Server Manager
GNU General Public License v2.0
160 stars 201 forks source link

Log BLOCK_JOB_COMPLETED error #395

Open dupondje opened 1 year ago

dupondje commented 1 year ago

The BLOCK_JOB_COMPLETED event contains some additional info and and error message when something failed. It would be useful to include the error message somewhere in vdsm/ovirt.

Line from libvirt logs:

4114448: info : qemuMonitorJSONIOProcessLine:205 : QEMU_MONITOR_RECV_EVENT: mon=0x7f1a9c0082f0 event={"timestamp": {"seconds": 1688026018, "microseconds": 64056}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "commit-sdb-libvirt-2-format", "len": 73747988480, "offset": 7143424, "speed": 0, "type": "commit", 
"error": "No space left on device"}}
nirs commented 5 months ago

@dupondje If this info is passed to vdsm in the event, vdsm can log it. You can check how vdsm handles the event and if we have more info in the event here: https://github.com/oVirt/vdsm/blob/126bb0df4a2c8050ce3d2f684172403603336256/lib/vdsm/clientIF.py#L647