search

oVirt / vdsm

The Virtual Desktop Server Manager
GNU General Public License v2.0
160 stars 201 forks source link

virt: v2v: parse progress from new virt-v2v #402

Closed nyoxi closed 9 months ago

nyoxi commented 10 months ago

Progress generated by virt-v2v has changed and is more graphical. This breaks the parser and causes the import to abort even when there is no real problem and virt-v2 completes successfully. Update the parsing logic to handle both old and new progress format.

nyoxi commented 10 months ago

Confirmed by a user on mailing list that the progress is now updated properly. From vdsm.log:

2023-10-26 16:04:15,862-0500 INFO  (v2v/4a6237d9) [root] Job '4a6237d9-05a0-4d5a-a7b1-ff01764a761f' copy disk 1 progress 80/100 (v2v:900)
[...]
2023-10-26 16:04:15,896-0500 INFO  (v2v/4a6237d9) [root] Job '4a6237d9-05a0-4d5a-a7b1-ff01764a761f' copy disk 1 progress 90/100 (v2v:900)
[...]
2023-10-26 16:04:17,437-0500 INFO  (v2v/4a6237d9) [root] Job '4a6237d9-05a0-4d5a-a7b1-ff01764a761f' copy disk 1 progress 100/100 (v2v:900)
2023-10-26 16:04:17,608-0500 INFO  (v2v/4a6237d9) [root] Job '4a6237d9-05a0-4d5a-a7b1-ff01764a761f' finished import successfully (v2v:875)
michalskrivanek commented 10 months ago

LGTM