search

oVirt / vdsm

The Virtual Desktop Server Manager
GNU General Public License v2.0
160 stars 201 forks source link

Backport: get gluster volume info from any gluster peer #414

Closed aesteve-rh closed 3 months ago

aesteve-rh commented 3 months ago

The function _get_gluster_volinfo query the glusterfs volume info the the storage server, this is translated to the gluster client adding the parameter --remote-host which limits the query to one server, so we are converting the storage server as a single point of failure, if it is not available, it can led to cluster outtage. The proposed changed let the cluster cli to use any available gluster peer.

Bug-Url: https://bugzilla.redhat.com/2264175

Signed-off-by: José Enrique Gutiérrez Mazón josgutie@redhat.com

aesteve-rh commented 3 months ago

As for functionality, I trust the reviews from master.

The typos in code comments can be addressed in master but please separate the commit title from the rest by a blank line to prevent some git clients to present the whole commit message as a heading. And break the excessively long lines in the commit message.

I did not notice the issue with the commit message in the original patch... But at least we can fix it in the backport, true. Just pushed the change. Thanks for checking!