oVirt / vdsm

The Virtual Desktop Server Manager
GNU General Public License v2.0
160 stars 201 forks source link

virt: remove bandwidth limit on nic update #416

Closed dupondje closed 2 months ago

dupondje commented 3 months ago

There was some logic error in the update_bandwidth_xml function. If you have a running VM with a NIC that has a QoS, it will contain a bandwidth setting in the XML. Now if you change the NIC to a vNIC Profile without QoS, it will not contain the 'inbound' and 'outbound' specParams, and the old QoS will never get removed (only after stop/start).

So we take the removal of the bandwidth out of the if so the limit gets cleared correctly.