search

oVirt / vdsm

The Virtual Desktop Server Manager
GNU General Public License v2.0
160 stars 201 forks source link

[IMP] In some case, we might want to keep some lvm active #420

Open cvinh opened 1 month ago

cvinh commented 1 month ago
  • Add a test (potentially at lmv_test.py) covering the new config option and new the deactivate unused LVs logic.

I'm sorry, I don't know how to add Tests, I would make some bad copy-paste ... :-1:

cvinh commented 1 month ago

Can you please point me out where I could add the information in the documentation ?

aesteve-rh commented 1 month ago

I'm sorry, I don't know how to add Tests, I would make some bad copy-paste ... 👎

It's ok, start with something simple, and I can help you refine it. I think something similar to test_bootstrap would do. Just make sure you monkeypatch the KEEPACTIVE list.

You can see how to run the tests here: https://github.com/oVirt/vdsm/blob/master/doc/development.md#running-the-tests

$ tox -e storage

Check pytest documentation if you are unfamiliar: https://docs.pytest.org/en/8.2.x/getting-started.html You can also check for other tests within the project.