Build with Lerna? - Githubissues

oacore / design

Design Elements is shared components library for CORE. Made with ❤️ and React

https://design.oacore.now.sh

5 stars 0 forks source link

Build with Lerna? #219

Open viktor-yakubiv opened 4 years ago

viktor-yakubiv commented 4 years ago

I think this repository comes to the stage where we need multiple packages even if we use all of them together. We want here having:

global CSS
styled React components
logo (#217)
icons
some pure HTML templates ⌛️(maybe in the future)

If some external project starts using our style (i doubt it) it may not need to depend on our logo or components, only CSS may be needed. It may be useful even for us, for example for the BSDTAg which is on pure HTML.

It's more for the discusssion. @Joozty what do you think?

Joozty commented 4 years ago

Totally agree even it will make maintenance slightly harder. Thanks for bringing it up. 👍

I see the packages slightly differently

@oacore/foundation - sanitize.css, assets (favicons, logo), global.css -deployed under cdn.core.ac.uk @oacore/templates - templates used for 404, 500 and everything shared between projects (for example cookies notice?) @oacore/icons - not sure about it but it's probably needed @oacore/design - everything else

viktor-yakubiv commented 3 years ago

I recently discovered an alternative to Lerna: pnpm.js. I saw, Rollup builds their plugins using pnpm.js. I wonder if this is something worth to consider.