search

oae / gnome-shell-pano

Next-gen Clipboard Manager for Gnome Shell
https://extensions.gnome.org/extension/5278/pano/
GNU General Public License v2.0
1.04k stars 55 forks source link

Font Scaling not considered #104

Closed amadeusp closed 1 year ago

amadeusp commented 1 year ago

If you change the font scaling in Tweaks, Pano does not take this into account. This means that Pano still shows the same small font size even with scaling values of e.g. 1.5 or 2, instead of (as expected) displaying the font larger according to the defined scaling factor. Attached are two screen grabs with 1.5 and 2 as scaling factor.

https://unsee.cc/album#9sL44KfBiMvJ3rkc https://unsee.cc/album#upykN8Gp5iLyklwE

My system:

Arcitec commented 1 year ago

@oae I agree with this. Pano is beautiful but it's also totally unreadable on my 4K screen.

Two things are needed:

  1. Apply the screen scaling factor from the GNOME screen that it's rendering Pano on. I use 200% on my screen. So let's say your current Pano font is 14px, which means that on my screen, it currently appears like if it's 7px (super small) because Pano's font isn't being scaled properly for the DPI of this screen. With proper scaling it would render the font at 14x2 = 28px. The "title" text on pano which says stuff like "Link" or "Text" is readable, but the sub-info like "about 1 hour ago" and the text previews are too small to be readable.
  2. Also would be VERY USEFUL to have an actual font size percentage slider inside Pano's settings, to be able to further fine-tune the relative font size.

Here's the algorithm I envision:

( Pano'sIntendedFontSize (ie 14px) * SettingsScaleFactor (50%-400%, ie 125%) ) * GNOMEScreenScaleFactor (ie 200%)

Meaning:

( 14px * 1.25 ) * 2.0 = 35px

Maybe rounding it to the nearest integer to avoid fractional fonts, which may not be optimal for rendering.

This would solve everything! :)

oae commented 1 year ago

I have added font customization. You can now change it in the settings.

image

Arcitec commented 1 year ago

@oae Wow that's a very detailed way to configure things. YOU'RE AWESOME! Thank you so much!

Arcitec commented 1 year ago

@oae

I have configured every font now and it's looking GREAT except for the headers. Please, is there any chance that you could also add a category named "Item Headers" at the top of the list, where we can set the font for the main label and the "timestamp" fields of all clipboard items universally?

I mean these ones at the top. :)

image

Arcitec commented 1 year ago

Oh and also the search font.

image

Maybe call the category:

oae commented 1 year ago

I have added related settings.

image

Arcitec commented 1 year ago

@oae Thank you sooooo much, thank you thank you! It's beautiful! :) This is the greatest clipboard manager ever made.