search

oae / gnome-shell-pano

Next-gen Clipboard Manager for Gnome Shell
https://extensions.gnome.org/extension/5278/pano/
GNU General Public License v2.0
1k stars 53 forks source link

Glitches in toggling Favorites / All #155

Open jasiralavibiztripz opened 1 year ago

jasiralavibiztripz commented 1 year ago

Description

  1. After Pano opens (with shortkeys) the focus is on the search box. Pressing the Alt key from here does not toggle Favorites. The Alt Key shortcut to toggle works only when focus is on the clipboard items.

  2. When there are no favorite items in the list, Pano is not able switch back to 'All items' with Alt key press. It gets stuck in the 'Favourites'. We need to click on the star with a mouse to switch back.

Expected Behavior

  1. Pressing Alt key, even when in the search box, should toggle between Favorites and All items

  2. Pressing Alt key, even when there are no items in the Favorites, should switch back to All items

Steps To Reproduce

Steps to reproduce 1:

  1. Open Pano
  2. When the focus is on Press Alt key. No toggle happens.

Steps to reproduce 2:

  1. Open Pano
  2. Make sure no items are favourited
  3. Press Alt to switch to Favorites, a blank space is shown (meaning no favorites)
  4. Press Alt again to switch back to All items. Nothing happens.
oae commented 1 year ago

I can't reproduce this. Can you check if you have any item-type filters like below? image

If you have any item type filter, it will show favorites based on that.

jasiralavibiztripz commented 1 year ago

It's got same behavior with and without filters. As you can see the alt key toggle works only when the focus is on one of the items, not when the focus is on the search box.

Screencast from 2023-03-08 02-10-41.webm

You can also see that when there is no item in favorites, I cant toggle back with the Alt key.

oae commented 1 year ago

Can you try disabling all extensions and check again? By any chance do you have any custom keyboard shortcut that uses alt? It maybe conflicting with that

marcinjahn commented 1 year ago

I have the same issue. I also noticed that clicking ALT in Pano, while Firefox is open messes up Firefox a bit - mouse wheel scrolling becomes undo/redo toggle. I have to press escape a bunch of times for this weird behavior to disappear.

CheariX commented 1 year ago

I have the the problem. Even if only pano extension is enabled. Maybe this is a wayland bug? All newly interoduced keyboard shortcuts do not work. Alt shows the behaviors as described above. ctrl-s is unfunctional. ctrl+number paste the first entry in most of the cases, rarely another one (offset by one), and barely to never the correct index. Very strange behavior.

Doesn't gnome provide an Api do disable all other shortcuts? flatpak permission-list gnome shortcuts-inhibitor Maybe this would be a solution?

oae commented 1 year ago

I am not able to reproduce these problems. All problems you mentioned work correctly for both X11 and Wayland. I even tried several distros inside vm. They all work. Can you please provide the logs so I can check for errors?