Issue tracker for Full GNOME 46 support

Totto16 commented 7 months ago

Since #264 adds support for gnome 46 it should be good in terms of GJS changes, but while working on #265 I noticed some changes in the gnome-shell UI libraries, we also use. There are some changes that I, and presumably others didn't notice, since e.g. Source from here doesn't have showNotification anymore since GNOME 46, but it's called addNotification. But the types suggested it before, so while fixing types over at https://github.com/gjsify/gnome-shell we should check, if we need to change more types to check for gnome 45 / 46 compatibility at runtime.

Task list:

[x] fix types for gnome 46 and 45 compatibility #264 and #265
[ ] remove highlights.js code highlighting, and make it something users have to install manually or user an alternative (e.g. source-highlight (see https://github.com/oae/gnome-shell-pano/pull/264#issuecomment-2026022132), this is to comply with EGO guidlines #278
[x] fix full-screen error in gnome 46 #263 #277

Optional:

[x] #266 - fix long standing bug

RushingAlien commented 7 months ago

I would like to add that due to direct scanout for full screen windows under Wayland, pano will fail do display when a window is fullscreen, the solution for this is using Meta.disable_unredirect_for_display() when the pano dialog/panel pops up. References on how to do this can be found in https://github.com/G-dH/window-thumbnails/commit/bb875073c8584bb1fbac3eb0ebf123384d4abdd2 and https://github.com/icedman/search-light/commit/25b43eab35adcaf50f5e3c58a84d9af8a29745cd.

This is only needed until GNOME supports overlay planes which will allow layered and non-fullscreen direct scanout.

Note from window-thumbnail dev about disable_unredirect: https://github.com/G-dH/window-thumbnails/issues/7#issuecomment-1997187140

Totto16 commented 7 months ago

I would like to add that due to direct scanout for full screen windows under Wayland, pano will fail do display when a window is fullscreen, the solution for this is using Meta.disable_unredirect_for_display() when the pano dialog/panel pops up. References on how to do this can be found in G-dH/window-thumbnails@bb87507 and icedman/search-light@25b43ea.

This is only needed until GNOME supports overlay planes which will allow layered and non-fullscreen direct scanout.

Note from window-thumbnail dev about disable_unredirect: G-dH/window-thumbnails#7 (comment)

Thanks for the suggestion 👍🏼 I will test that and also fix it 👍🏼

marcinjahn commented 6 months ago

@Totto16 The README mentions Gnome 46 as being supported, while EGO is still on Gnome 45. I assume that I could just get the latest zip from Releases and it will work on G46, right? It seems that the only "issue" there is highlight.js still being embedded.

Totto16 commented 6 months ago

@marcinjahn Correct, the "issue" with highlight.js is, that EGO doesn't want to have that too much third party dependencies in published extensions. So The master branch fully supports GNOME 46, but for a release on EGO I have to complete #278 (which might take some time).

To install it locally, follow the steps here

You have to download the latest files from the master branch tough, the latest release doesn't support gnome 46 yet and we didn't make a new release yet 😓

marcinjahn commented 6 months ago

Sure, thanks for the clarification!

theGeekyLad commented 6 months ago

Does this issue also pertain to GNOME 46.1 (currently breaking)?

Totto16 commented 6 months ago

Does this issue also pertain to GNOME 46.1 (currently breaking)?

Not really, this is mainly for Gnome 46.0 support (and the EGO release for that) .

That said, just open a new issue with the exact details and I'll look into it separately. The EGO topic might take a while. But fixing compatibility for gnome 46.1 would take a higher priority.

This is really interesting, since minor releases shouldn't break anything, but I'm not surprised, gnome 45.3 broke some things too 🤦🏼‍♂️

oae commented 6 months ago

I tested the master branch on 46.1 and saw no issues.

Totto16 commented 6 months ago

I tested the master branch on 46.1 and saw no issues.

Interesting, then he probably meant the public EGO release 😓 Or am I wrong @theGeekyLad

talesam commented 6 months ago

Testei a filial principal em 46.1 e não vi problemas.

I am one of the Biglinux Devs and I take care of the Gnome version, it is on 46.1 and is based on Manjaro and it is not working, it says that the extension is not compatible with version 46.1

Totto16 commented 6 months ago

Testei a filial principal em 46.1 e não vi problemas.

I am one of the Biglinux Devs and I take care of the Gnome version, it is on 46.1 and is based on Manjaro and it is not working, it says that the extension is not compatible with version 46.1

The version on EGO doesn't yet support 46 due to some concern on some third party libraries from the side of the EGO reviewers, we are working on that, see #278

but you can self "compile" (transpile) the master branch and than it works

Malix-Labs commented 6 months ago

Is there an ETA as of when pano will be available for Gnome 46 ?

Totto16 commented 6 months ago

Is there an ETA as of when pano will be available for Gnome 46 ?

I have started to do the needed work, quite a while ago, (see #278 ) but I had some "more important" things to do, so I didn't have time for quite a while, I can use the extension by self building it so it also climbed down my priority list 😓 (which is kinda egostic and not a good excuse 😓 ).

I see that there is "high" demand and that Gnome 46 is out on many distros for a while (almost a month on Ubuntu, Fedora etc.) So I am trying my best to schedule the needed work for as soon as possible 😓

logicito commented 6 months ago

Is there an ETA as of when pano will be available for Gnome 46 ?

I have started to do the needed work, quite a while ago, (see #278 ) but I had some "more important" things to do, so I didn't have time for quite a while, I can use the extension by self building it so it also climbed down my priority list 😓 (which is kinda egostic and not a good excuse 😓 ).

I see that there is "high" demand and that Gnome 46 is out on many distros for a while (almost a month on Ubuntu, Fedora etc.) So I am trying my best to schedule the needed work for as soon as possible 😓

Thank you very much, there is no better clipboard manager than Pano

daethlor commented 6 months ago

@marcinjahn Correct, the "issue" with highlight.js is, that EGO doesn't want to have that too much third party dependencies in published extensions. So The master branch fully supports GNOME 46, but for a release on EGO I have to complete #278 (which might take some time).

To install it locally, follow the steps here

You have to download the latest files from the master branch tough, the latest release doesn't support gnome 46 yet and we didn't make a new release yet 😓

On 24.04, when trying to self build I get:

00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'install'
00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'build'

Would love to have even partial usability on 24.04 at this point.

back-lacking commented 5 months ago

is there an eta on gnome 45/46 support or is it currently still unknown?

Totto16 commented 5 months ago

I published a pre-release, that has to be installed manually, but at least you don't need to self-built the extension. Until I finally fix everything, and we can release it on EGO, it might take a while😓

7system7 commented 5 months ago

OMG. This extension is (sadly) irreplaceable. Thank you.

johnstonesnow commented 5 months ago

I published a pre-release, that has to be installed manually, but at least you don't need to self-built the extension. Until I finally fix everything, and we can release it on EGO, it might take a while😓

Hi, is there any chance someone could explain how to install it please? I am on Fedora 40 and lost without Pano. thanks

Vinnl commented 5 months ago

@johnstonesnow Information about the prelease can be found here.

From that page, download pano@elhan.io.zip. Open Files, click the path bar at the top and enter ~/.local/share/gnome-shell/extensions/ and press Enter. Copy the downloaded file into that folder, then open it to extract its contents into that folder. Next time you login, the extension should work.

johnstonesnow commented 5 months ago

Thanks very much. Just to check, are you sure about that location? I went to it in FIles and I wonder if I need to go a level deeper, to put the extracted contents into the pano folder itself, can you confirm please? here's what I have in that folder string you gave me...

Vinnl commented 5 months ago

@johnstonesnow Ah yes, that's the old version of Pano that's still installed - extracting the .zip will give you a new version of that folder. You can rename or delete the existing one, or alternatively, first uninstall the existing extension before following the steps I outlined above.

johnstonesnow commented 5 months ago

Ah, great thanks. Forgive my ignorance, but if I uninstall the old one (not even sure how but will look that up), wont I need to install the new one? I was under the impression this was just a patch to fix a current installation,maybe its a full manual installation? thanks again

Vinnl commented 5 months ago

It is indeed a full manual installation - extracting the .zip into that directory is installing it (the prerelease).

johnstonesnow commented 5 months ago

Great, will give it a whirl. thanks

johnstonesnow commented 5 months ago

PS Just had a thought. I am thinking of trying out KDE Plasma DE on Fedora. I have never used it, fairly new to Linux overall. Am I right in thinking, if i were to switch to KDE, Pano will probably work (as it seems the issue is with Gnome DE)? thanks

logicito commented 5 months ago

PS Just had a thought. I am thinking of trying out KDE Plasma DE on Fedora. I have never used it, fairly new to Linux overall. Am I right in thinking, if i were to switch to KDE, Pano will probably work (as it seems the issue is with Gnome DE)? thanks

Pano is a Gnome extension, it only works with Gnome

Totto16 commented 5 months ago

PS Just had a thought. I am thinking of trying out KDE Plasma DE on Fedora. I have never used it, fairly new to Linux overall. Am I right in thinking, if i were to switch to KDE, Pano will probably work (as it seems the issue is with Gnome DE)? thanks

No, Pano only works with Gnome. KDE is another DE (Desktop Environment). Pano is a gnome extension and therefore only works with Gnome. It also uses a lot of Gnome specific features and on KDE there are other clipboard managers that you can use 😓

johnstonesnow commented 5 months ago

Oops, this is the part where I look dumb :D Thanks. I just played with KDE a bit and whilst it has some VERY nice features, it has others I don't like as much as Gnome's equivalent. I am gonna stick with Gnome, partly just to keep Pano :)

lorenzo0932 commented 5 months ago

Hi, i know that is an alpha right now, but after installing the extension in gnome 46 my vrr doesn't work anymore. I know that is strange but i tested with my monitor osd in vrrTest and some games and when pano is disabled vrr works.

I'm the only one with this problem?

Dkoeddnsnp commented 5 months ago

I'm the only one with this problem?

I have this issue as well. I took me a lot of time to find what causes the vrr to break.

thyttan commented 4 months ago

BUG:

Single-finger tap (left mouse button click) on icon opens clipboard AND top bar menu.
Tap again hides the top bar menu.
Tap a third time hides the clipboard.

EXPECTED:

To only display the clipboard. (One click should show. If I click again it should hide)

SYSTEM

Fedora Linux 40 About 20 other extensions

Can anyone confirm they see this too?

Not sure if this only happens on Gnome 46 or on older versions as well.

Totto16 commented 4 months ago

@lorenzo0932 @Dkoeddnsnp Could you file a separate issue for the bug. Then I'll look into it ❤️

Totto16 commented 4 months ago

BUG:
* Single-finger tap (left mouse button click) on icon opens clipboard AND top bar menu.

* Tap again hides the top bar menu.

* Tap a third time hides the clipboard.
EXPECTED:

To only display the clipboard. (One click should show. If I click again it should hide)

SYSTEM

Fedora Linux 40 About 20 other extensions

Can anyone confirm they see this too?

Not sure if this only happens on Gnome 46 or on older versions as well.

Could you please file a seperate issue, thank you ❤️

iconoclasthero commented 4 months ago

I'm not sure this is the same error:

$ sudo apt install gir1.2-gda-5.0 gir1.2-gsound-1.0
gir1.2-gda-5.0 is already the newest version (5.2.10-4.1build1).
gir1.2-gsound-1.0 is already the newest version (1.0.3-3.2build2).

$ neofetch
OS: Rhino Linux 2024.1 (server) x86_64 
Kernel: Linux 6.9.1-060901-generic 
DE: GNOME 46.2 (Wayland) 
WM: Mutter

edit:

just found this in extensions ... i was looking in extension manager before. great they're so distinct-sounding:

The settings of extension pano@elhan.io had an error:

SyntaxError: import declarations may only appear at top level of a module @ resource:///org/gnome/Shell/Extensions/js/misc/extensionUtils.js:4:0

Stack trace:
  @file:///home/$USER/.local/share/gnome-shell/extensions/pano@elhan.io/prefs.js:2:12
  _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

If it is not, the alpha fixes the above errors so...

Just for future reference, is it standard to put the files in a zip like that without putting them in a directory? I was expecting to just unzip pano@....zip.

Seqaeon commented 4 months ago

Screenshot from 2024-07-24 19-46-42

Stilll not working in GNOME 46

teohhanhui commented 4 months ago

@Seqaeon You have to use https://github.com/oae/gnome-shell-pano/releases/tag/v23-alpha2

Seqaeon commented 4 months ago

That worked. Thanks a lot @teohhanhui.

A small question, it seems to copy everything I double click and I can't seem to see an option to get it to only copy stuff I press CTRL +C on

teohhanhui commented 4 months ago

it seems to copy everything I double click and I can't seem to see an option to get it to only copy stuff I press CTRL +C on

It's in the settings. You'd want to use an extension manager like https://flathub.org/apps/com.mattjakeman.ExtensionManager (the best) to be able to access extension settings in general. But for Pano, you can right click on the widget and go to Settings.

Seqaeon commented 4 months ago

it seems to copy everything I double click and I can't seem to see an option to get it to only copy stuff I press CTRL +C on

It's in the settings. You'd want to use an extension manager like https://flathub.org/apps/com.mattjakeman.ExtensionManager (the best) to be able to access extension settings in general. But for Pano, you can right click on the widget and go to Settings.

I was using the gnome-extension app to edit its settings but couldn't figure out how to make it stop. image_2024-07-25_00-54-32 image_2024-07-25_00-54-21

hockdudu commented 4 months ago

It's under "sync primary"

Seqaeon commented 4 months ago

It's under "sync primary"

I disabled that and it didn't change

Seqaeon commented 4 months ago

It's under "sync primary"

image_2024-07-25_10-04-05

See trying to select some stuff and it starts copying straight from the first character selected. Also like each cell I try to move from in a spreadsheet is copied

hockdudu commented 4 months ago

Weird... This setting should disable exactly that. Are the settings being actually persisted? What's the output of the following command?

dconf dump /org/gnome/shell/extensions/pano/

It should output this line, among others

sync-primary=false

Seqaeon commented 4 months ago

Weird... This setting should disable exactly that. Are the settings being actually persisted? What's the output of the following command?
dconf dump /org/gnome/shell/extensions/pano/
It should output this line, among others
sync-primary=false

`[/]

global-shortcut=['v']

history-length=500

icon-pack=uint32 0

incognito-shortcut=['v']

item-size=200

paste-on-select=true

sync-primary=false

window-position=uint32 0 `

hockdudu commented 4 months ago

Strange... Does this persist when you restart the computer? Maybe is another extension or tool conflicting with this extension, could you try disabling other extensions and seeing if this persists?

If this doesn't work, I believe it's best to open a new issue, as this seems to be a bug.

Seqaeon commented 4 months ago

Strange... Does this persist when you restart the computer? Maybe is another extension or tool conflicting with this extension, could you try disabling other extensions and seeing if this persists?

If this doesn't work, I believe it's best to open a new issue, as this seems to be a bug.

Wow, it's been fixed, the issue seems to be I had GPaste also installed.

zvictor commented 1 month ago

For anyone interested, this is how I managed to run v23-alpha2 in Nix:

gnome-shell-extension-pano.patch:


--- a/extension.js
+++ b/extension.js
@@ -1,3 +1,7 @@
+import GIRepository from 'gi://GIRepository';
+GIRepository.Repository.prepend_search_path('@gda_path@');
+GIRepository.Repository.prepend_search_path('@gsound_path@');

import Gio from 'gi://Gio'; import GLib from 'gi://GLib'; import * as extension_js from 'resource:///org/gnome/shell/extensions/extension.js';

gnome-shell-extension-pano.nix:


{ stdenv, fetchzip, lib, gnome, glib, libgda, gsound, substituteAll, wrapGAppsHook }:

stdenv.mkDerivation rec { pname = "gnome-shell-extension-pano"; version = "v23-alpha2";

src = fetchzip { url = "https://github.com/oae/gnome-shell-pano/releases/download/${version}/pano@elhan.io.zip"; sha256 = "Y8WgVUHX094RUwYKdt7OROPZMl3dakK0zOU9OTdyqxc="; stripRoot = false; };

patches = [ (substituteAll { src = ./gnome-shell-extension-pano.patch; gsound_path = "${gsound}/lib/girepository-1.0"; gda_path = "${libgda}/lib/girepository-1.0"; }) ];

buildInputs = [ gnome.gnome-shell libgda gsound ];

nativeBuildInputs = [ wrapGAppsHook ];

installPhase = '' runHook preInstall local_ext_dir=$out/share/gnome-shell/extensions/pano@elhan.io install -d $local_ext_dir cp -r * $local_ext_dir

# Ensure typelibs are directly accessible
mkdir -p $out/lib/girepository-1.0
ln -s ${gsound}/lib/girepository-1.0/* $out/lib/girepository-1.0/
ln -s ${libgda}/lib/girepository-1.0/* $out/lib/girepository-1.0/

runHook postInstall

'';

meta = with lib; { description = "Pano GNOME Shell Clipboard Management Extension (${version} pre-release)"; homepage = "https://github.com/oae/gnome-shell-pano"; license = licenses.gpl2Plus; platforms = platforms.linux; maintainers = [ maintainers.zvictor ]; };

EmreKaratopuk commented 3 weeks ago

Thank you for the pre-release, it works very well. Is there an ETA for full Gnome 46 support?

carmen-gh commented 2 weeks ago

and here comes Gnome 47 with latest Fedora release... I hope I can use it someday again :)

oae / gnome-shell-pano