search

oae / gnome-shell-pano

Next-gen Clipboard Manager for Gnome Shell
https://extensions.gnome.org/extension/5278/pano/
GNU General Public License v2.0
1.07k stars 57 forks source link

[BUG] Opening the content preview also opens the contextual menu #283

Closed JE-Amouel closed 4 months ago

JE-Amouel commented 4 months ago

Description

What is the bug? open content preview also open contextual menu.

Problem Explanation

if i open content's preview, pano's contextual menu also appear.

The bug happens when ... i try to open content's preview with the mouse cursor only.

Environment

Screencast

Screencast_05_16_2024_11:01:16_AM.webm

Malix-Labs commented 4 months ago

If I'm not mistaken, Pano is not yet compatible with Gnome 46

Totto16 commented 4 months ago

If I'm not mistaken, Pano is not yet compatible with Gnome 46

It is compatible, just not yet on EGO 😓 see #271

Totto16 commented 4 months ago

Description

What is the bug? open content preview also open contextual menu.

Problem Explanation

if i open content's preview, pano's contextual menu also appear.

The bug happens when ... i try to open content's preview with the mouse cursor only.

Environment

* GNOME Shell version: 46

* Distro: fedoda

* Distro version: 40

Screencast

Screencast_05_16_2024_11.01.16_AM.webm

I noticed that too, but since I'm not here since the beginning, I always assumed, that that was intended like this, it looks really weird, when the panel is on the right, but if it's in the bottom it is alright. I sometimes use this feature, when I'm currently navigating with the mouse, instead of using the shortcut to open it. 🤷🏼‍♂️

@oae Was this intended like this, or not?

oae commented 4 months ago

It seems like the below commit broke this function. Only the right click should open the popup menu.

https://github.com/oae/gnome-shell-pano/commit/2361af0ba76b2b9c20853636fd3c1329bc6f140d#diff-5cedbb3beb837d1b671d8202c9dd333d301088645922f2a32ee7a82b1a69aebaL115-L125

Malix-Labs commented 4 months ago

@Totto16

It is compatible, just not yet on EGO 😓

Nice to hear it's halfway there I don't know what "EGO" is thought

Gnome 46 display a tooltip that says

This extension is incompatible with your current version of GNOME Screenshot from 2024-05-20 13-42-30

Totto16 commented 4 months ago

@Totto16

It is compatible, just not yet on EGO 😓

Nice to hear it's halfway there I don't know what "EGO" is thought

Gnome 46 display a tooltip that says

This extension is incompatible with your current version of GNOME Screenshot from 2024-05-20 13-42-30

EGO refers to https://extensions.gnome.org/

Yes, you need to compile it yourself atm unfortunately, see #271